Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #36639

Merged
merged 5 commits into from
Nov 5, 2024
Merged

fix typos #36639

merged 5 commits into from
Nov 5, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested review from a team as code owners November 4, 2024 02:53
@OnkarRuikar OnkarRuikar requested review from sideshowbarker, chrisdavidmills and pepelsbey and removed request for a team November 4, 2024 02:53
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-11-05 05:29:09)

Josh-Cena
Josh-Cena reviewed Nov 4, 2024
View reviewed changes
files/en-us/web/css/css_text/wrapping_breaking_text/index.md Outdated
@@ -163,11 +165,11 @@ In the example below there is a checkbox and label. Let's say, you want the labe

## Adding hyphens

To add hyphens when words are broken, use the CSS {{cssxref("hyphens")}} property. Using a value of `auto`, the browser is free to automatically break words at appropriate hyphenation points, following whatever rules it chooses. To have some control over the process, use a value of `manual`, then insert a hard or soft break character into the string. A hard break (`‐`) will always break, even if it is not necessary to do so. A soft break (`­`) only breaks if breaking is needed.
To add hyphens when words are broken, use the CSS {{cssxref("hyphens")}} property. Using a value of `auto`, the browser is free to automatically break words at appropriate hyphenation points, following whatever rules it chooses. To have some control over the process, use a value of `manual`, then insert a hard (`-`) or soft break character (U+00AD) into the string. A soft break character can be added using `­`, `­`, or `&#xad` HTML character codes as well. A hard break will always break, even if it is not necessary to do so. A soft break only breaks if breaking is needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the "hard break character" from ‐ (U+2010) to - (U+002D). I have no idea which one is correct; @bsmth I think it's you?

Also for the Welsh name below feel free to add the parts of it to ignore-list instead since it would never be confused with a valid word.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. U+2010 is the authentic hyphen, and U+002D is ASCII minus/dash. But both seem to work without any difference.

Suggested change
To add hyphens when words are broken, use the CSS {{cssxref("hyphens")}} property. Using a value of `auto`, the browser is free to automatically break words at appropriate hyphenation points, following whatever rules it chooses. To have some control over the process, use a value of `manual`, then insert a hard (`-`) or soft break character (U+00AD) into the string. A soft break character can be added using `­`, `­`, or `&#xad` HTML character codes as well. A hard break will always break, even if it is not necessary to do so. A soft break only breaks if breaking is needed.
To add hyphens when words are broken, use the CSS {{cssxref("hyphens")}} property. Using a value of `auto`, the browser is free to automatically break words at appropriate hyphenation points, following whatever rules it chooses. To have some control over the process, use a value of `manual`, then insert a hard (U+2010) or soft break character (U+00AD) into the string. A hard break character can be added using `‐` or `‐`, and a soft break character can be added using `­`, `­`, or `&#xad` HTML character codes. A hard break will always break, even if it is not necessary to do so. A soft break only breaks if breaking is needed.

@github-actions github-actions bot added the Content:Learn:HTML Learning area HTML docs label Nov 5, 2024
@Josh-Cena Josh-Cena merged commit 587c39b into mdn:main Nov 5, 2024
9 checks passed
@OnkarRuikar OnkarRuikar deleted the typos branch November 5, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker sideshowbarker is a code owner automatically assigned from mdn/yari-content-web-api

@chrisdavidmills chrisdavidmills Awaiting requested review from chrisdavidmills chrisdavidmills is a code owner automatically assigned from mdn/yari-content-html

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:Learn:HTML Learning area HTML docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weekly spelling check
2 participants
@OnkarRuikar @Josh-Cena